Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12271#discussion_r59501466
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -488,7 +488,7 @@ class HiveSqlAstBuilder extends SparkSqlAstBuilder {
// just convert the whole type string to lower case, otherwise the
struct field names
// will no longer be case sensitive. Instead, we rely on our
parser to get the proper
// case before passing it to Hive.
- HiveMetastoreTypes.toDataType(col.dataType.getText).simpleString,
+ CatalystSqlParser.parseDataType(col.dataType.getText).simpleString,
--- End diff --
MINOR/NIT: The DataType parsing is done in the `AstBuilder`, so we really
don't need to parse this string again. You could use (magical/evil)
`typedVisit[DataType](col.dataType)` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
