Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11635#discussion_r60361860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -958,6 +958,26 @@ object PushDownPredicate extends Rule[LogicalPlan]
with PredicateHelper {
project.copy(child = Filter(replaceAlias(condition, aliasMap),
grandChild))
+ // Push [[Filter]] operators through [[Window]] operators. Parts of
the predicate that can be
+ // pushed beneath must satisfy three conditions:
+ // 1. involving one and only one column that is part of window
partitioning key.
--- End diff --
I think we can push any deterministic predicate down as all of its
references are part of the partition key. So why limit this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
