Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11635#discussion_r60410517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -958,6 +958,26 @@ object PushDownPredicate extends Rule[LogicalPlan] with PredicateHelper { project.copy(child = Filter(replaceAlias(condition, aliasMap), grandChild)) + // Push [[Filter]] operators through [[Window]] operators. Parts of the predicate that can be + // pushed beneath must satisfy three conditions: + // 1. involving one and only one column that is part of window partitioning key. + // 2. Window partitioning key should be just a sequence of [[AttributeReference]]. + // 3. deterministic + case filter@Filter(condition, w: Window) + if w.partitionSpec.forall(_.isInstanceOf[AttributeReference]) => + val (pushDown, stayUp) = splitConjunctivePredicates(condition).partition { cond => + cond.references.size == 1 && + cond.references.subsetOf(AttributeSet(w.partitionSpec.flatMap(_.references))) && --- End diff -- Sure, will do. Thanks!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org