Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60776463
--- Diff:
yarn/src/test/scala/org/apache/spark/network/yarn/YarnShuffleServiceSuite.scala
---
@@ -87,8 +87,10 @@ class YarnShuffleServiceSuite extends SparkFunSuite with
Matchers with BeforeAnd
val execStateFile = s1.registeredExecutorFile
execStateFile should not be (null)
- val shuffleInfo1 = new ExecutorShuffleInfo(Array("/foo", "/bar"), 3,
"sort")
- val shuffleInfo2 = new ExecutorShuffleInfo(Array("/bippy"), 5, "hash")
+ val shuffleInfo1 = new ExecutorShuffleInfo(Array("/foo", "/bar"), 3,
+ "org.apache.spark.shuffle.sort.SortShuffleManager")
--- End diff --
Since you did it for other tests, you could have a constant here for the
name too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
