Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12568#discussion_r60687198
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -183,12 +190,7 @@ public ManagedBuffer getBlockData(String appId, String
execId, String blockId) {
String.format("Executor is not registered (appId=%s, execId=%s)",
appId, execId));
}
- if ("sort".equals(executor.shuffleManager) ||
"tungsten-sort".equals(executor.shuffleManager)) {
- return getSortBasedShuffleBlockData(executor, shuffleId, mapId,
reduceId);
- } else {
- throw new UnsupportedOperationException(
- "Unsupported shuffle manager: " + executor.shuffleManager);
- }
+ return getSortBasedShuffleBlockData(executor, shuffleId, mapId,
reduceId);
--- End diff --
I think it is not necessary. Because if it is other shuffleManager, it can
not find it from executor list. As before, it will throw a
UnsupportedOperationException. see:
[https://github.com/apache/spark/blob/5e92583d38e11d39deb429a39725443111205a4a/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java#L181](url)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
