Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12660#discussion_r61391277
  
    --- Diff: python/pyspark/ml/tests.py ---
    @@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
                                        ": expected " + str(expected[i]) + ", 
got " + str(features[i]))
     
     
    +class ALSTest(PySparkTestCase):
    +
    +    def test_storage_levels(self):
    --- End diff --
    
    +1 on removing this. We just need to test the default values and the 
setters actually set the value on JVM side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to