Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61393700
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + str(expected[i]) + ",
got " + str(features[i]))
+class ALSTest(PySparkTestCase):
+
+ def test_storage_levels(self):
--- End diff --
Ok will test just param setters. Just for clarity, what do you mean by "set
the value on the JVM side"? Do you want to check that
`getIntermediateRDDStorageLevel` returns the correct value, or check that the
value of the underlying JavaEstimator param is correct?
By the way, I have made these params part of `ALSParams` and not
`ALSModelParams` because setting them in the model does nothing. However, I
could provide getters in the model, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
