Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12846#discussion_r61800231
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala
---
@@ -86,6 +86,10 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new
SQLConf) {
sqlConf.getConf(entry)
}
+ protected[sql] def getOption[T](entry: OptionalConfigEntry[T]):
Option[T] = {
--- End diff --
I'd prefer to keep things similar to `SparkConf` and have this method be
just called `get`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
