Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/12846#discussion_r61808094 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable with CatalystConf with Logging { } /** + * Return the value of an optional Spark SQL configuration property for the given key. If the key + * is not set yet, returns None. + */ + def getOptionalConf[T](entry: OptionalConfigEntry[T]): Option[T] = { --- End diff -- Ideally its an `OptionalConf` so getConf should return `Option[T]`, but this will change the current behaviour(we won't be able to throw proper errors if the key is missing). In that case what we can do instead is something like this ```scala getConf(CHECKPOINT_LOCATION).getOrElse(throw new NoSuchElementException(CHECKPOINT_LOCATION.key)) ``` Suggestions ?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org