Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12968#discussion_r62428404
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)
/** @group getParam */
def getCaseSensitive: Boolean = $(caseSensitive)
- setDefault(stopWords ->
StopWordsRemover.loadDefaultStopWords("english"), caseSensitive -> false)
+ /**
+ * Locale for doing a case sensitive comparison
+ * Default: English locale ("en")
+ * @group param
+ */
+ val locale: Param[String] = new Param[String](this, "locale",
--- End diff --
For supported languages, we can know the appropriate locale and maintain an
internal mapping. So "french" is known to map to `Locale.FRENCH`. For loading
an arbitrary list, we don't know, but you could provide an overload where you
provide a `Locale`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
