Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12968#discussion_r62461327
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
@@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)
/** @group getParam */
def getCaseSensitive: Boolean = $(caseSensitive)
- setDefault(stopWords ->
StopWordsRemover.loadDefaultStopWords("english"), caseSensitive -> false)
+ /**
+ * Locale for doing a case sensitive comparison
+ * Default: English locale ("en")
+ * @group param
+ */
+ val locale: Param[String] = new Param[String](this, "locale",
+ "locale for doing a case sensitive comparison")
+
+ /** @group setParam */
+ def setLocale(value: String): this.type = set(locale, value)
+
+ /** @group getParam */
+ def getLocale: String = $(locale)
+
+ setDefault(stopWords -> StopWordsRemover.loadDefaultStopWords("english"),
+ caseSensitive -> false, locale -> "en")
--- End diff --
If the English set is loaded by default the locale should match, rather
than use the platform default
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
