Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/12994#discussion_r62500214
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
---
@@ -112,14 +118,15 @@ private boolean isAuthenticationEnabled() {
*/
@Override
protected void serviceInit(Configuration conf) {
+ _conf = conf;
// In case this NM was killed while there were running spark
applications, we need to restore
// lost state for the existing executors. We look for an existing
file in the NM's local dirs.
// If we don't find one, then we choose a file to use to save the
state next time. Even if
// an application was stopped while the NM was down, we expect yarn to
call stopApplication()
// when it comes back
registeredExecutorFile =
-
findRegisteredExecutorFile(conf.getTrimmedStrings("yarn.nodemanager.local-dirs"));
+ new File(getRecoveryPath().toUri().getPath(),
"registeredExecutors.ldb");
--- End diff --
I know you didn't change this but could you make a constant for
"registeredExecutors.ldb"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
