Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217873160 few minor comments but mostly looks good. Did you build against both hadoop 2.5+ and hadoop < 2.5? Did you manually test the upgrade path?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org