Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13104#discussion_r63584448
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
 ---
    @@ -65,6 +65,14 @@ class TextSuite extends QueryTest with SharedSQLContext {
         }
       }
     
    +  test("support for partitioned reading") {
    +    val df = spark.read.format("text").load(testDir)
    --- End diff --
    
    This semantic makes sense to me.  But can we generate the test files 
dynamically instead of checking them in? (thats what we do in all the other 
tests)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to