Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13104#discussion_r63659619
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -110,6 +118,10 @@ class TextSuite extends QueryTest with
SharedSQLContext {
Thread.currentThread().getContextClassLoader.getResource("text-suite.txt").toString
}
+ private def testDir: String = {
--- End diff --
actually this is a little bit far from the test case. since it is only used
once, why not move this into the test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
