Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63604166
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -348,13 +349,23 @@ object CreateDataSourceTableUtils extends Logging {
className = provider,
options = options)
- def newSparkSQLSpecificMetastoreTable(): CatalogTable = {
+ def newSparkSQLSpecificMetastoreTable(relation: HadoopFsRelation):
CatalogTable = {
CatalogTable(
identifier = tableIdent,
tableType = tableType,
schema = Nil,
storage = CatalogStorageFormat(
- locationUri = None,
+ // We don't want Hive metastore to implicitly create a table
directory,
+ // which may be not the one Data Source table is referring to,
+ // yet which will be left behind when the table is dropped for
an external table
+ locationUri = if (isExternal) {
--- End diff --
I think what we can do is to check if the options contains `path`. If so,
we put that at here. Otherwise, we leave locationUri as None.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
