Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63869408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -354,7 +356,27 @@ object CreateDataSourceTableUtils extends Logging {
tableType = tableType,
schema = Nil,
storage = CatalogStorageFormat(
- locationUri = None,
+ // We don't want Hive metastore to implicitly create a table
directory,
+ // which may be not the one Data Source table is referring to,
+ // yet which will be left behind when the table is dropped for
an external table
+ locationUri = if (new
CaseInsensitiveMap(options).get("path").isDefined) {
+ val path = new Path(new
CaseInsensitiveMap(options).get("path").get)
+ val fs =
path.getFileSystem(sparkSession.sessionState.newHadoopConf())
+ if (fs.exists(path)) {
+ // if the provided path exists, Hive metastore only takes
directory
+ // as table data location
+ if (fs.getFileStatus(path).isDirectory) {
+ Some(path.toUri.toString)
+ } else {
+ Some(path.getParent.toUri.toString)
+ }
+ } else {
+ // If the path does not exists yet, it is assumed to be
directory
+ Some(path.toUri.toString)
+ }
+ } else {
+ None
+ },
--- End diff --
The following line should be enough for `localtionUri`:
```scala
locationUri = new CaseInsensitiveMap(options).get("path")
```
Consider the following directory layout containing two Parquet files:
```
/tmp/dir/
part-00001.parquet
part-00002.parquet
```
If we pass "/tmp/dir/part-00001.parquet" as file path, the logic above will
use the "/tmp/dir/" as `locationUri`, thus "part-00002.parquet" is also
included, which is not the expected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
