Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/13223#discussion_r64026868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -134,7 +135,14 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
def set(bigintval: BigInteger): Decimal = {
try {
this.decimalVal = null
- this.longVal = bigintval.longValueExact()
+ // TODO: Remove this once we migrate to java8 and use
longValueExact() instead.
+ val isExactLong =
bigintval.compareTo(BigInteger.valueOf(JLong.MAX_VALUE)) <= 0 &&
+ bigintval.compareTo(BigInteger.valueOf(JLong.MIN_VALUE)) >= 0
+ if(isExactLong) {
--- End diff --
Since we don't need the try catch, this would be much better
```scala
def set(bigintval: BigInteger): Decimal = {
this.decimalVal = null
// TODO: Remove this once we migrate to java8 and use longValueExact()
instead.
val isExactLong = bigintval.compareTo(LONG_MAX_BIG_INT) <= 0 &&
bigintval.compareTo(LONG_MIN_BIG_INT) >= 0
if (isExactLong) {
this.longVal = bigintval.longValue()
} else {
throw new IllegalArgumentException(s"BigInteger ${bigintval} too
large for decimal")
}
this._precision = DecimalType.MAX_PRECISION
this._scale = 0
this
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
