Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13223#discussion_r64031221
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -174,7 +176,7 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
def toScalaBigInt: BigInt = BigInt(toLong)
- def toJavaBigInteger: java.math.BigInteger =
java.math.BigInteger.valueOf(toLong)
+ def toJavaBigInteger: BigInteger = BigInteger.valueOf(toLong)
--- End diff --
Although I support removing the redundant qualified name, I wonder if we
should also un-qualify scala.math.BigInt, or else leave both qualified even
though they're not ambiguous. BigDecimal is used unqualified while the Java
version is always qualified, to disambiguate. I guess it would become
consistent if BigInt were not qualified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
