Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8559#discussion_r64169565
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala 
---
    @@ -59,7 +59,7 @@ private[spark] class DirectTaskResult[T](
     
         val numUpdates = in.readInt
         if (numUpdates == 0) {
    -      accumUpdates = null
    +      accumUpdates = Seq()
    --- End diff --
    
    I'm a little surprised that we were getting away with that, given the 
number of places that are using DirectTaskResult#accumUpdates without checking 
for null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to