Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/8559#discussion_r64170026
--- Diff:
core/src/test/resources/META-INF/services/org.apache.spark.scheduler.ExternalClusterManager
---
@@ -1 +1,2 @@
-org.apache.spark.scheduler.DummyExternalClusterManager
\ No newline at end of file
+org.apache.spark.scheduler.DummyExternalClusterManager
+org.apache.spark.scheduler.MockExternalClusterManager
--- End diff --
Did you ever look at combining DummyExternalClusterManager and
MockExternalClusterManager? They are just two variations on a fake
ExternalClusterManager for use in tests. I realize that the focus of the tests
for Dummy... and Mock... are different, so the two variations may not be easy
or clean to combine, but if we could have just one fake ExternalClusterManager
that still had a relatively clean implementation, I think that would be better
than maintaining two. OTOH, if combining them gets messy, then just go with
what you've already got.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
