GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/13269
[SPARK-15494][SQL] encoder code cleanup
## What changes were proposed in this pull request?
Our encoder framework has been evolved a lot, this PR tries to clean up the
code to make it more readable and emphasise the concept that encoder should be
used as a container of serde expressions.
1. move validation logic to analyzer instead of encoder
2. only have a `resolveAndBind` method in encoder instead of `resolve` and
`bind`, as we don't have the encoder life cycle concept anymore.
3. `Dataset` don't need to keep a resolved encoder, as is no such concept
anymore. bound encoder is still needed to do serialization outside of query
framework.
## How was this patch tested?
existing test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark clean-encoder
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13269.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13269
----
commit 73e9c1abec9ac22bb6e1370b0dcd44714b0acf71
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2016-05-23T23:38:42Z
encoder code cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
