Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13264#discussion_r64314987
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala
---
@@ -59,7 +59,15 @@ class StorageListener(storageStatusListener:
StorageStatusListener) extends Bloc
override def onStageSubmitted(stageSubmitted:
SparkListenerStageSubmitted): Unit = synchronized {
val rddInfos = stageSubmitted.stageInfo.rddInfos
- rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info) }
+ rddInfos.foreach { info =>
--- End diff --
Hm I'm not so sure if it's safe to just replace it. We mutate the RDD Infos
in `onBlockUpdate`, where the cached information is most update to date. I'm
not sure if there is an ordering between `StageSubmitted` and `BlockUpdated`
that can cause the cached information to be overridden.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
