Github user lgieron commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13264#discussion_r64448718
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala 
---
    @@ -59,7 +59,15 @@ class StorageListener(storageStatusListener: 
StorageStatusListener) extends Bloc
     
       override def onStageSubmitted(stageSubmitted: 
SparkListenerStageSubmitted): Unit = synchronized {
         val rddInfos = stageSubmitted.stageInfo.rddInfos
    -    rddInfos.foreach { info => _rddInfoMap.getOrElseUpdate(info.id, info) }
    +    rddInfos.foreach { info =>
    +      _rddInfoMap.get(info.id) match {
    +        case Some(rddInfo) if info.name != rddInfo.name =>
    +          rddInfo.name = info.name
    +        case None =>
    +          _rddInfoMap(info.id) = info
    +        case _ =>
    --- End diff --
    
    If we take out `case _ =>`, then won't have a match for cached rddInfo 
whose name wasn't changed - resulting in exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to