Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13150#issuecomment-221417642 This looks good. Just two minor nits. If you can fix those that would be great. Also - would it be possible to add a test case?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org