Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13150#discussion_r64504540
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
    @@ -68,6 +71,51 @@ class StatisticsSuite extends QueryTest with 
TestHiveSingleton {
           classOf[AnalyzeTableCommand])
       }
     
    +  test("MetastoreRelations fallback to HDFS for size estimation") {
    +    val enableFallBackToHdfsForStats = 
hiveContext.conf.fallBackToHdfsForStatsEnabled
    +    try {
    +      withTempDir { tempDir =>
    +
    +        // EXTERNAL OpenCSVSerde table pointing to LOCATION
    +
    +        val file1 = new File(tempDir + "/data1")
    +        val writer1 = new PrintWriter(file1)
    +        writer1.write("1,2")
    +        writer1.close()
    +
    +        val file2 = new File(tempDir + "/data2")
    +        val writer2 = new PrintWriter(file2)
    +        writer2.write("1,2")
    +        writer2.close()
    +
    +        sql(
    +          s"""CREATE EXTERNAL TABLE csv_table(page_id INT, impressions INT)
    +        ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.OpenCSVSerde'
    --- End diff --
    
    need to indent this properly. I can fix this when I merge if Jenkins passes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to