Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13348#discussion_r64853158
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -55,7 +56,7 @@ object SQLConf {
val WAREHOUSE_PATH = SQLConfigBuilder("spark.sql.warehouse.dir")
.doc("The default location for managed databases and tables.")
.stringConf
- .createWithDefault("${system:user.dir}/spark-warehouse")
+ .createWithDefault("${system:user.dir}" + File.separator +
"spark-warehouse")
--- End diff --
Although the path points to a local dir, this path is actually a hadoop
filesystem path. So, I am wondering if we need to use `File.separator` at here?
If we are running on Windows, does a hadoop filesystem path uses `\` as the
separator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
