Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13348#discussion_r64858511
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -665,7 +666,8 @@ private[sql] class SQLConf extends Serializable with 
CatalystConf with Logging {
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
       def warehousePath: String = {
    -    getConf(WAREHOUSE_PATH).replace("${system:user.dir}", 
System.getProperty("user.dir"))
    +    getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
    +      new 
File(System.getProperty("user.dir")).toURI.toURL.toString).replace("//", "/")
    --- End diff --
    
    In my local mac osx, `new 
File(System.getProperty("user.dir")).toURI.toURL.toString)` will generate a 
file path with a trailling `/`. 
    
    I am afraid this could be OS dependent? Thus, I did not change the default 
value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to