Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13348#discussion_r64858995
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -55,7 +56,7 @@ object SQLConf {
       val WAREHOUSE_PATH = SQLConfigBuilder("spark.sql.warehouse.dir")
         .doc("The default location for managed databases and tables.")
         .stringConf
    -    .createWithDefault("${system:user.dir}/spark-warehouse")
    +    .createWithDefault("${system:user.dir}" + File.separator + 
"spark-warehouse")
    --- End diff --
    
    Why not just change the default value to 
`file:/${system:user.dir}/spark-warehouse`? I do not really understand why we 
have to change `def warehousePath`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to