Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r64871473 --- Diff: R/pkg/inst/worker/worker.R --- @@ -84,67 +84,78 @@ broadcastElap <- elapsedSecs() # as number of partitions to create. numPartitions <- SparkR:::readInt(inputCon) -isDataFrame <- as.logical(SparkR:::readInt(inputCon)) +# 0 - RDD mode, 1 - dapply mode, 2 - gapply mode +mode <- SparkR:::readInt(inputCon) -# If isDataFrame, then read column names -if (isDataFrame) { +# If DataFrame - mode = 1 and mode = 2, then read column names +if (mode > 0) { --- End diff -- To improve code readability, better not use mode directly. you can ``` if (mode > 0) { isDataFrame = TRUE if (mode == 1) { dapply = TRUE } else { gapply = TRUE } } else { isDataFrame = FALSE dapply = FALSE gapply = FALSE } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org