Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/12836#discussion_r64992518 --- Diff: R/pkg/inst/worker/worker.R --- @@ -84,67 +84,78 @@ broadcastElap <- elapsedSecs() # as number of partitions to create. numPartitions <- SparkR:::readInt(inputCon) -isDataFrame <- as.logical(SparkR:::readInt(inputCon)) +# 0 - RDD mode, 1 - dapply mode, 2 - gapply mode +mode <- SparkR:::readInt(inputCon) -# If isDataFrame, then read column names -if (isDataFrame) { +# If DataFrame - mode = 1 and mode = 2, then read column names +if (mode > 0) { --- End diff -- ``` Thnx @sun-rui ! Maybe it will be better to have smth like: ``` isDataFrame = FALSE dapply = FALSE gapply = FALSE if (mode > 0) { isDataFrame = TRUE if (mode == 1) { dapply = TRUE } else { gapply = TRUE } } ``` because in your example, we'd also need to set, gapply = FALSE and dapply = FALSE accordingly is mode > 0. Smth like: if (mode == 1) { dapply = TRUE gapply = FALSE } else { dapply = FALSE gapply = TRUE } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org