Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13552#discussion_r66251417
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -353,7 +353,7 @@ private[yarn] class YarnAllocator(
     
         } else if (missing < 0) {
           val numToCancel = math.min(numPendingAllocate, -missing)
    -      logInfo(s"Canceling requests for $numToCancel executor containers")
    +      logInfo(s"Canceled requests for $numToCancel executor container(s)")
    --- End diff --
    
    Maybe update the "Driver requested a total..." message to include what the 
previous target was then? If I'm right (not entirely sure) then I think it 
could tell us that the "driver has now requested 614 executors, which differs 
from previous target of 619".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to