Github user peterableda commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13552#discussion_r66262459
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -353,7 +353,7 @@ private[yarn] class YarnAllocator(
     
         } else if (missing < 0) {
           val numToCancel = math.min(numPendingAllocate, -missing)
    -      logInfo(s"Canceling requests for $numToCancel executor containers")
    +      logInfo(s"Canceled requests for $numToCancel executor container(s)")
    --- End diff --
    
    We can show the old value of course but it doesn't solve my problem.
    
    16/06/07 18:53:48 INFO yarn.YarnAllocator: Driver requested a total number 
of 614 executor(s).
    16/06/07 18:53:48 INFO yarn.YarnAllocator: Canceling requests for 5 
executor containers
    
    It says Driver requested 614 executors (so it supposed to be already 
happened). But then it says Canceling 5 executors (it is happening now). This 
is not correct. The 614 executor is less with 5 executors then the previous 
status update (619).
    
    The root cause is that these two messages are swapped, this would make 
total sense:
    16/06/07 18:53:48 INFO yarn.YarnAllocator: Canceling requests for 5 
executor containers
    16/06/07 18:53:48 INFO yarn.YarnAllocator: Driver requested a total number 
of 614 executor(s).
    
    The minimum change to fix this is the one introduced in this pull request, 
just to reword the Cancel message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to