Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9571#discussion_r66612954
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -114,28 +123,45 @@ class HistoryServer(
* this UI with the event logs in the provided base directory.
*/
def initialize() {
- attachPage(new HistoryPage(this))
+ if (!initialized.getAndSet(true)) {
--- End diff --
It's in `HistoryServerSuite`
```scala
server = new HistoryServer(conf, provider, securityManager, 18080)
server.initialize()
server.bind()
```
issue here is the HS constructor already calls `initialize()`; some of the
tests call it twice.
One option here would be move that `initialize()` out of the constructor of
HS; that'd mean changing `main()`, but produce something better for subclassing
and testing anyway. Even so, making `initialize()` non-reentrant can only be a
good thing, given that threads are spawned off, metrics registered, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
