Github user yangw1234 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13585#discussion_r66714468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -92,6 +92,36 @@ object PhysicalOperation extends PredicateHelper {
.map(Alias(_, a.name)(a.exprId, a.qualifier, isGenerated =
a.isGenerated)).getOrElse(a)
}
}
+
+ /**
+ * Drop the non-partition key expression in the disjunctions, to
optimize the partition pruning.
--- End diff --
It is `(part=1 conjunction a=1) disjunction (part=2 conjunction a=4)`,
right? But the expression get dropped is `a=1` which is in "conjunction" with
`part=1` and `a=4` which is in "conjunction" with `part=2`. So I thought it
should be conjunctions.
Or maybe we can phrase it in another way to avoid the confusion? ^_^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
