Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/13585#discussion_r66714698
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -92,6 +92,36 @@ object PhysicalOperation extends PredicateHelper {
.map(Alias(_, a.name)(a.exprId, a.qualifier, isGenerated =
a.isGenerated)).getOrElse(a)
}
}
+
+ /**
+ * Drop the non-partition key expression in the disjunctions, to
optimize the partition pruning.
--- End diff --
Oh, OK, originally, I think the conjunction cases was handled in
`collectProjectsAndFilters` already, before being passed into this function,
and here, we only handle the `AND` in the disjunction. (You can see this in
HiveTableScans in HiveStrategies.scala)
Anyway, you convinced me. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
