Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13638#discussion_r66880127
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -155,8 +156,9 @@ private[sql] class CacheManager extends Logging {
* function will over invalidate.
*/
private[sql] def invalidateCache(plan: LogicalPlan): Unit = writeLock {
+ val canonicalized = plan.canonicalized
cachedData.foreach {
- case data if data.plan.collect { case p if p.sameResult(plan) => p
}.nonEmpty =>
+ case data if data.plan.collect { case p if
p.sameResult(canonicalized) => p }.nonEmpty =>
--- End diff --
I don't think so.
For example, if the cached plan is `LocalRelation` (which is canonicalized)
and the `plan` argument is `SubqueryAlias(LocalRelation)` (which is not
canonicalized), it will fail to find the same-result plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
