Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13638#discussion_r66887975
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -87,7 +87,7 @@ private[sql] class CacheManager extends Logging {
query: Dataset[_],
tableName: Option[String] = None,
storageLevel: StorageLevel = MEMORY_AND_DISK): Unit = writeLock {
- val planToCache = query.queryExecution.analyzed
+ val planToCache = query.queryExecution.analyzed.canonicalized
--- End diff --
do we still need these changes? `LogicalPlan.canonicalized` is a lazy val
and we don't have performance penalty even we use un-canonicalized plan as key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
