Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/1760#discussion_r15981109
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
---
@@ -95,7 +101,9 @@ class TestHiveContext(sc: SparkContext) extends
HiveContext(sc) {
* Replaces relative paths to the parent directory "../" with
hiveDevHome since this is how the
* hive test cases assume the system is set up.
*/
- private def rewritePaths(cmd: String): String =
+ private def rewritePaths(cmd: String): String = {
+ // For some hive test case which contain ${system:test.tmp.dir}
+ System.setProperty("test.tmp.dir", testTmpDir.getCanonicalPath)
--- End diff --
OK, make sense.
* Maybe it's better move this line out of function rewritePaths, as it may
be called multiple times.
* In addition, we also have to delete the temporal folder after unit test
finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
