Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1760#discussion_r16005429
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala
---
@@ -70,6 +70,12 @@ class TestHiveContext(sc: SparkContext) extends
HiveContext(sc) {
set("hive.metastore.warehouse.dir", warehousePath)
}
+ val testTmpDir = if (System.getProperty("user.dir").endsWith("sql" +
File.separator + "hive")) {
+ new File(System.getProperty("user.dir") + File.separator + "tmp")
--- End diff --
in repo tests is checking to see if the tests are there or if we should
look for them in the hive distribution (they weren't always bundled with the
source tree). If we need a temporary directory, we should use the mechanisms
provided by the JVM for that (`File.createTempFile`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
