Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13758#discussion_r67745192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
@@ -142,3 +164,415 @@ class GenericArrayData(val array: Array[Any]) extends
ArrayData {
result
}
}
+
+final class GenericIntArrayData(private val primitiveArray: Array[Int])
--- End diff --
I think the class hierarchy is a bit off. We should make `GenericArrayData`
abstract and introduce a `GenericeRefArrayData` as a replacement for the
current `GenericArrayData`.
The downside of the introducing this many `ArrayData` classes is that
`ArrayData` operations will be mega-morphic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
