Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13758#discussion_r67850981
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
@@ -142,3 +164,415 @@ class GenericArrayData(val array: Array[Any]) extends
ArrayData {
result
}
}
+
+final class GenericIntArrayData(private val primitiveArray: Array[Int])
+ extends GenericArrayData(Array.empty) {
+ override def array(): Array[Any] = primitiveArray.toArray
+
+ override def copy(): ArrayData = new GenericIntArrayData(primitiveArray)
+
+ override def numElements(): Int = primitiveArray.length
+
+ override def isNullAt(ordinal: Int): Boolean = false
+ override def getInt(ordinal: Int): Int = primitiveArray(ordinal)
+ override def toIntArray(): Array[Int] = {
+ val array = new Array[Int](numElements)
+ System.arraycopy(primitiveArray, 0, array, 0, numElements)
+ array
+ }
+ override def toString(): String = primitiveArray.mkString("[", ",", "]")
+
+ override def equals(o: Any): Boolean = {
--- End diff --
Good question about the definition of equality. Interestingly, there is no
```hashCode()``` and ```equals()``` methods in
[UnsafeArrayData](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java).
During my works regarding code generation, I cannot find any usage of
```hashCode()``` and ```equals()``` methods. Is it better to drop these two
methods if all of the tests would pass without these two methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
