Github user gurvindersingh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13950#discussion_r68826228
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala ---
    @@ -77,7 +77,15 @@ private[ui] class ApplicationPage(parent: MasterWebUI) 
extends WebUIPage("app")
                 <li><strong>State:</strong> {app.state}</li>
                 {
                   if (!app.isFinished) {
    -                <li><strong><a href={app.desc.appUiUrl}>Application Detail 
UI</a></strong></li>
    +                <li><strong>
    +                  {
    +                    if (parent.master.reverseProxy) {
    +                      <a href={"/target/" + app.id + "/"}>Application 
Detail UI</a>
    --- End diff --
    
    By all means it can be a configuration value, but there were already some 
literal conventions eg. "app" so I thought of having it this way. But if 
community prefer the configured value, then I will add that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to