Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/13950#discussion_r68842364
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -127,7 +128,14 @@ private[deploy] class Master(
logInfo(s"Running Spark version ${org.apache.spark.SPARK_VERSION}")
webUi = new MasterWebUI(this, webUiPort)
webUi.bind()
- masterWebUiUrl = "http://"; + masterPublicAddress + ":" +
webUi.boundPort
+ if (reverseProxy) {
+ masterWebUiUrl = conf.get("spark.ui.reverseProxyUrl", null)
--- End diff --
Is there a reason we need this config? Would there ever be a case where the
proxy URL is different from the master URL? Also from my testing this config is
completely ignored (as long as it exists)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
