Github user squito commented on the issue:
https://github.com/apache/spark/pull/14079
@kayousterhout @markhamstra @tgravescs @mwws I finally this is ready for
review. I have some minor updates left but I wanted to get this in your hands
now. The main thing is testing on a cluster (would appreciate any input from
you on this as well Tom).
One big change in implementation I'd like to highlight: the
blacklisttracker no longer requires locks. Though its accessed by multiple
threads, its (almost) always from some place in TaskSschedulerImpl, which
already has a lock on the taskScheduler. This also requires expiring executors
while we're doing other work (rather than in a background thread) -- I chose to
do it inside the call to `taskScheduler.resourceOffer`.
The one exception to having a lock on taskScheduler is the YarnBackend --
it needs the full set of blacklisted nodes, and it does that without a lock a
on the task scheduler. But this was pretty easy to workaround.
I'll drop a few inline comments as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
