Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/14079#discussion_r69849058 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -236,29 +246,41 @@ private[spark] class TaskSchedulerImpl( * given TaskSetManager have completed, so state associated with the TaskSetManager should be * cleaned up. */ - def taskSetFinished(manager: TaskSetManager): Unit = synchronized { + def taskSetFinished(manager: TaskSetManager, success: Boolean): Unit = synchronized { taskSetsByStageIdAndAttempt.get(manager.taskSet.stageId).foreach { taskSetsForStage => taskSetsForStage -= manager.taskSet.stageAttemptId if (taskSetsForStage.isEmpty) { taskSetsByStageIdAndAttempt -= manager.taskSet.stageId } } manager.parent.removeSchedulable(manager) - logInfo("Removed TaskSet %s, whose tasks have all completed, from pool %s" - .format(manager.taskSet.id, manager.parent.name)) + if (success) { + blacklistTracker.taskSetSucceeded(manager.taskSet.stageId, this) + logInfo(s"Removed TaskSet ${manager.taskSet.id}, whose tasks have all completed, from pool" + + s" ${manager.parent.name}") + } else { + blacklistTracker.taskSetFailed(manager.taskSet.stageId) + logInfo(s"Removed TaskSet ${manager.taskSet.id}, since it failed, from pool" + + s" ${manager.parent.name}") --- End diff -- Changing the log msg is unrelated to blacklisting, but this msg had always annoyed / confused me earlier, so I thought it was worth updating since i needed `success` anyway.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org