Github user lovexi commented on a diff in the pull request:
https://github.com/apache/spark/pull/14080#discussion_r70111868
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java
---
@@ -64,6 +75,10 @@ public ExternalShuffleBlockHandler(TransportConf conf,
File registeredExecutorFi
public ExternalShuffleBlockHandler(
OneForOneStreamManager streamManager,
ExternalShuffleBlockResolver blockManager) {
+ this.metrics = new ShuffleMetrics();
+ this.timeDelayForOpenBlockRequest =
metrics.timeDelayForOpenBlockRequest;
+ this.timeDelayForRegisterExecutorRequest =
metrics.timeDelayForRegisterExecutorRequest;
--- End diff --
Yeah, it seems like kind of extra. Already remove local ones and reference
them directly from metrics class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
