Github user lovexi commented on a diff in the pull request: https://github.com/apache/spark/pull/14080#discussion_r70115043 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockHandler.java --- @@ -143,4 +179,26 @@ private void checkAuth(TransportClient client, String appId) { } } + /** + * A simple class to wrap all shuffle service wrapper metrics + */ + private class ShuffleMetrics implements MetricSet { + private final Map<String, Metric> allMetrics; + private final Timer timeDelayForOpenBlockRequest = new Timer(); + private final Timer timeDelayForRegisterExecutorRequest = new Timer(); + private final Meter transferBlockRate = new Meter(); --- End diff -- Thank you for suggestions. That makes variable names much better. Already addressed it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org