Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13990#discussion_r70382521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -393,3 +394,89 @@ case class CreateNamedStructUnsafe(children:
Seq[Expression]) extends Expression
override def prettyName: String = "named_struct_unsafe"
}
+
+/**
+ * Creates a map after splitting the input text into key/value pairs using
delimeters
+ */
+@ExpressionDescription(
+ usage = "_FUNC_(text[, pairDelim, keyValueDelim]) - Creates a map after
splitting the text " +
+ "into key/value pairs using delimiters. " +
+ "Default delimiters are ',' for pairDelim and ':' for keyValueDelim.",
+ extended = """ > SELECT _FUNC_('a:1,b:2,c:3',',',':');\n
map("a":"1","b":"2","c":"3") """)
+case class StringToMap(text: Expression, pairDelim: Expression,
keyValueDelim: Expression)
+ extends TernaryExpression with ExpectsInputTypes {
+
+ def this(child: Expression, pairDelim: Expression) = {
+ this(child, pairDelim, Literal(":"))
+ }
+
+ def this(child: Expression) = {
+ this(child, Literal(","), Literal(":"))
+ }
+
+ override def children: Seq[Expression] = Seq(text, pairDelim,
keyValueDelim)
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(StringType,
StringType, StringType)
+
+ override def dataType: DataType = MapType(StringType, StringType,
valueContainsNull = false)
+
+ override def eval(input: InternalRow): Any = {
+ val exprs = children
+ val value1 = exprs(0).eval(input)
+ if (value1 != null) {
+ val value2 = exprs(1).eval(input)
+ if (value2 != null) {
+ val value3 = exprs(2).eval(input)
+ if (value3 != null) {
+ val array = value1.asInstanceOf[UTF8String]
+ .split(value2.asInstanceOf[UTF8String], -1)
+ .map { kv =>
+ val arr = kv.split(value3.asInstanceOf[UTF8String], 2)
+ if(arr.length < 2) {
+ Array(arr(0), null)
+ } else {
+ arr
+ }
+ }
+ return ArrayBasedMapData(array.map(_(0)), array.map(_(1)))
+ }
+ }
+ }
+ throw new AnalysisException("All arguments should be a string
literal.")
--- End diff --
This should be done in `checkInputTypes`, not here inside `eval` at runtime
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
