Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/13990#discussion_r70559727
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -393,3 +394,54 @@ case class CreateNamedStructUnsafe(children:
Seq[Expression]) extends Expression
override def prettyName: String = "named_struct_unsafe"
}
+
+/**
+ * Creates a map after splitting the input text into key/value pairs using
delimeters
+ */
+@ExpressionDescription(
+ usage = "_FUNC_(text[, pairDelim, keyValueDelim]) - Creates a map after
splitting the text " +
+ "into key/value pairs using delimiters. " +
+ "Default delimiters are ',' for pairDelim and ':' for keyValueDelim.",
+ extended = """ > SELECT _FUNC_('a:1,b:2,c:3',',',':');\n
map("a":"1","b":"2","c":"3") """)
+case class StringToMap(text: Expression, pairDelim: Expression,
keyValueDelim: Expression)
+ extends TernaryExpression with CodegenFallback{
+
+ def this(child: Expression, pairDelim: Expression) = {
+ this(child, pairDelim, Literal(":"))
+ }
+
+ def this(child: Expression) = {
+ this(child, Literal(","), Literal(":"))
+ }
+
+ override def children: Seq[Expression] = Seq(text, pairDelim,
keyValueDelim)
+
+ override def dataType: DataType = MapType(StringType, StringType,
valueContainsNull = false)
+
+ override def checkInputDataTypes(): TypeCheckResult = {
+ if (children.map(_.dataType).forall(_ == StringType)) {
+ TypeCheckResult.TypeCheckSuccess
+ } else if (Seq(pairDelim, keyValueDelim).forall(_.foldable)) {
+ TypeCheckResult.TypeCheckFailure(s"String To Map's all arguments
must be of type string.")
+ } else {
+ TypeCheckResult.TypeCheckFailure(
--- End diff --
First all children should have dataType StringType, if they don't and
delims are foldable fail using args must be string. else they are not foldable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
